CASL / Futility

VERA Fortran Utilities
Other
44 stars 20 forks source link

Mark unit tests appropriately for build system #199

Closed mattkab2 closed 4 years ago

mattkab2 commented 5 years ago

In ctest, we can specify categories for unit tests and set which ones get run with a flag (i.e. ctest -L BASIC). This patch adds all unit tests to the BASIC category so that all configurations (heavy, nightly, continuous, basic) know to run them when passed the -L flag.

djabaay commented 4 years ago

After looking at this, I understand Brendan's comment better. We should be able to just specify the CATEGORIES BASIC within all the Futility unit tests.

bkochuna commented 4 years ago

Also, would like to get some buy in from @stimpsonsg and @aarograh for this change. I'm assuming it doesn't change the test name (e.g. you can't filter tests by ctest -R BASIC, just ctest -L BASIC)

aarograh commented 4 years ago

I'm not well versed in the details of tribits, but I'm definitely in favor of the idea behind this change. Being able to just configure a single build with heavies enabled then use ctest -L BASIC or ctest -L CONTINUOUS to only run a subset would be helpful.

bkochuna commented 4 years ago

Dan, can you approve?

bkochuna commented 4 years ago

Changes look good to me. I'm wondering why the travis-ci isn't running on this though...

bkochuna commented 4 years ago

Nevermind. Found it running.

bkochuna commented 4 years ago

It also didn't run correctly. I think because of an issue with the docker image. It does not appear to have HDF5...

stimpsonsg commented 4 years ago

https://github.com/CASL/Futility/issues/132

bkochuna commented 4 years ago

Thanks Shane. Anyone working on that issue?

stimpsonsg commented 4 years ago

Nope...feel free to go nutz

bkochuna commented 4 years ago

I rebased this onto master and forced pushed here.

bkochuna commented 4 years ago

Not sure... if the autobuild status will update here now or not. The link to the build associated with this is:

https://travis-ci.org/CASL/Futility/builds/604621994

bkochuna commented 4 years ago

Well the build passed. But this page didn't update... might be a separate issue... I'll test under a VERA build before merging and report back.

bkochuna commented 4 years ago

Everything checked out for me in manual testing. I think this is ready to go.

@stimpsonsg are there any concerns from your side on pushing this?

stimpsonsg commented 4 years ago

Seems good to me