Changing .travis.yml to use && instead of ;

CASL / Futility

VERA Fortran Utilities

Other

44 stars 20 forks source link

Changing .travis.yml to use && instead of ; #200

Closed bkochuna closed 4 years ago

bkochuna commented 4 years ago

Description: In bash when chaining commands, the && will only execute the next command if the previous command had a return value of 0. When using ; it will execute the next command regardless of the return code.

Not sure how TravisCI treats the error code in reporting errors, so I'm hoping this reveals the issue.

Github Issue - #132

bkochuna commented 4 years ago

Followed this build on travis-ci and it definitely returns a failed status after replacing ; with &&. See here: https://travis-ci.org/CASL/Futility/jobs/603104260

bkochuna commented 4 years ago

Don't know why this page didn't update. But. The build passed on travis-ci here: https://travis-ci.org/CASL/Futility/builds/603108633

bkochuna commented 4 years ago

@stimpsonsg will you have time to review?

stimpsonsg commented 4 years ago

yeah, I'll get to it today