search

CASL / Futility

VERA Fortran Utilities
Other
44 stars 20 forks source link

Temperature Conversion Functions #242

Closed stimpsonsg closed 4 years ago

stimpsonsg commented 4 years ago

Adds temperature conversion functions and unit testing.

HendersonSC commented 4 years ago

I agree with @aarograh I think it is perfectly reasonable to expect the client to only use physically meaningful temperatures. If they don't then we can still do the conversion, but its up to them to catch the mistake somewhere along the line.

stimpsonsg commented 4 years ago

Alright, I agree that the DBC check is of minimal benefit. Upgraded all routines to elemental.

stimpsonsg commented 4 years ago

when the heck is this CI ever going to fire off?

aarograh commented 4 years ago

The build has passed: https://travis-ci.org/github/CASL/Futility

Something's up with the Travis to Github status update, but the code itself is fine. Merging this in