search

CASL / Futility

VERA Fortran Utilities
Other
44 stars 20 forks source link

Native Solver 2: The GMRESurrection #261

Closed mattkab2 closed 4 years ago

mattkab2 commented 4 years ago

Now with 10% more testing than the next leading brand. Previous pull request link: https://github.com/CASL/Futility/pull/231

The problem was discovered to be related to the orthogonalization section of the GMRES solver. This has been addressed by changing the communication pattern slightly, which was easiest to do in a slightly older version of the solver.

This branch passes all tests in the MPACT checkin script I could run. There was only one Heavy test I could not run, which depends on ORIGEN. I will upload the logs from these tests soon (Friday, most likely).

aarograh commented 4 years ago

Thanks, Matt. I'll check this out soon, but regardless we'll probably hold the merge until the VERA release candidate has been tagged (probably next week some time). Once that and the review are done, we can merge this in.

mattkab2 commented 4 years ago

@aarograh no problem.

I'm attaching a diff of the differences between this pull request and the previous one. Note some changes show up as they pertain to VectorResemble_Alloc and VectorResembleAlloc; it seems someone else created these routines as well, and they were merged into Futility while I worked on fixing the merge.

Pretty much all the changes are concentrated in the solveGMRES_partial routine. Diff/Patch file

mattkab2 commented 4 years ago

Checkin test log on the NativeGMRES branch: checkin_test.log

aarograh commented 4 years ago

And one final question for @mattkab2 : you ran all those transient cases that failed before and they passed, correct? I see the check-in script log, but it doesn't actually list the tests that were run.

mattkab2 commented 4 years ago

@aarograh That's correct, those transient cases all work perfectly well now.

aarograh commented 4 years ago

Alright, good.

As I mentioned, we'll leave this on a branch until the RC6 tag, but once that's tagged I'll go ahead and merge assuming no other concerns come up before then.

aarograh commented 4 years ago

RC6 has been tagged and the sync ran and passed last night, so I think this is a good time to go ahead and merge this.