search

CASL / Futility

VERA Fortran Utilities
Other
44 stars 20 forks source link

Failure to converge newton solve in BDF ODE step causes inf loop #269

Closed wgurecky closed 4 years ago

wgurecky commented 4 years ago

The nonlinear solve in the BDF solve step can get stuck in an inf loop:

https://github.com/CASL/Futility/blob/850865ef0691b8732b7b54e873071ccbfc7b6490/src/ODESolverTypes.f90#L679

This can occur if the Jacobian approximation is not sufficiently accurate for the given step or if user sets updateJ_in to .FALSE. then this increases chance of triggering an infinite loop.