search

CASL / Futility

VERA Fortran Utilities
Other
44 stars 20 forks source link

Adding subroutines for Find interface for searching strings. #281

Closed djabaay closed 4 years ago

djabaay commented 4 years ago

Description: Fixing another issue with array utils assigning the first value as unique, even if it is null. Changing that to loop over all values instead.

CASL Ticket # - PHI 6419

djabaay commented 4 years ago

Please review when you get a chance @aarograh.

aarograh commented 4 years ago

@djabaay I plan to leave this until after we tag RC7 unless it's a critical fix for the release. We can go ahead and get things lined up to merge once the tag is complete though.

djabaay commented 4 years ago

I'll need this for the BWR maps if we want that in RC7, which I thought we did. I'll fix the documentation issues right now.

aarograh commented 4 years ago

I wasn't aware of that. @bscollin or @bkochuna can correct me if I'm wrong, but based on discussion in the VERA leads meeting yesterday, I think we're planning to tag monday/tuesday and pretty much holding anything that's not a defect fix at this point.

aarograh commented 4 years ago

It looks like a Travis build ran successfully on this and the status juts isn't making it back. I'm going to go ahead and merge.