search

CASL / Futility

VERA Fortran Utilities
Other
44 stars 20 forks source link

Native SpMV Kernel Update and nnz changes #316

Closed mattkab2 closed 3 years ago

mattkab2 commented 3 years ago

This merge updates the native SpMV kernel to require less communication by creating a communication map at assemble-time, meaning each processor knows the destination of incoming data as it appears when computing the matrix-vector product.

This merge also adds compatibility to the native types with the PETSc onnz/dnnz parameters which sidesteps a int/long conversion problem for the nnz parameterlist entry, which has a different meaning in the PETSc/Native case.

mattkab2 commented 3 years ago

This merge now contains a patch to the CI which resolves a python error mismatch, preventing installation of pytables. The CI is still running, but the line which caused the error (the pip install script) is no longer exiting with an error code.

The heavy tests in MPACT are being run with this merge, as well as serial-debug to ensure these changes don't cause errors. Results will be posted here when available.

bkochuna commented 3 years ago

Removing Shane from review. He's changed jobs. Adding Aaron instead.

aarograh commented 3 years ago

@mattkab2 looks like you managed to fix that stupid pip issue that's been plaguing our Futility CI for awhile. Thanks for getting that one figured out! I'm actually going to cherry-pick that change into a separate PR so we can get the CI cleaned up while you work on resolving Brendan's comments.

mattkab2 commented 3 years ago

I've just realized that I never posted the update on the tests;

MPACT built with this branch passes all the heavies/serial debug tests that are currently passing on master. There are a handful (~10) that are showing as failing for me on both, but those are mostly due to missing XS libraries (though there are a few failing COBRA_TF tests on master I have no explanation for).

mattkab2 commented 3 years ago

@bkochuna @aarograh the MPACT build with this passes all the checks I can throw at it. Could one of you review and merge when you get the chance? Thanks.

bkochuna commented 3 years ago

This looks fine to me. I'm good with merging. The TRAVIS-CI did actually finish successfully (you can see it in details). Not sure why it hasn't updated here.

@aarograh anything else you want to see here?

aarograh commented 3 years ago

@bkochuna nope. You can approve and merge if you deem it ready