CASM-Consulting / springcrawler

Apache License 2.0
0 stars 0 forks source link

[READY] Re-scrape console command #41

Closed andehr closed 3 years ago

andehr commented 3 years ago
simonwibberley commented 3 years ago

@andehr could you put implementations in a service? I'm trying to keep the ShellRunner class clean, it just marshals arguments to implementations and shouldn't have any business logic in it...

andehr commented 3 years ago

Sure, I wasn't sure how much of the logic of quite a specific command should be put in general services. So maybe just add a rescrape function to the scraperService which delegates to the datetimeService whenever needed?

simonwibberley commented 3 years ago

@andehr Would have thought the scraper service would be a good place...