marking this as a draft PR because I still need to handle situations where there are duplicate samples or nonexistent samples passed via the samples parameter. We didn't have to worry about this before because cyvcf2 would handle it for us, but it's probably a good idea to think about now that we are actually treating the samples parameter as a list instead of a set
also I should disable the warning by passing reorder_samples=False in all of the places where it doesn't matter
aryarm
commented
9 months ago
marking this as a draft PR because I still need to handle situations where there are duplicate samples or nonexistent samples passed via the
samplesparameter. We didn't have to worry about this before because cyvcf2 would handle it for us, but it's probably a good idea to think about now that we are actually treating the samples parameter as a list instead of a setalso I should disable the warning by passing
reorder_samples=Falsein all of the places where it doesn't matter