search

CAST-genomics / haptools

Ancestry and haplotype aware simulation of genotypes and phenotypes for complex trait analysis
https://haptools.readthedocs.io
MIT License
18 stars 4 forks source link

docs: fix example of `.blocks.det` to `.hap` conversion in API docs #236

Closed aryarm closed 8 months ago

aryarm commented 8 months ago

resolves #235

There were a few bugs in the blocks2hap example in the API docs!

In d06d50a27b1ae847a044e9bb287ed186c58aa53f, we fix those bugs. And in aa5d4efebe9bce35846a75a74951c63fc358452d, we convert that example code into a test so we can properly maintain it going forward.

aryarm commented 8 months ago

The tests successfully pass on my local machine, so I think the CI is just having another hissy fit

The CI is revamped in #207 , so merging that will probably resolve these issues, anyway. Let's just wait until that's merged before trying to merge this

mlamkin7 commented 8 months ago

The tests successfully pass on my local machine, so I think the CI is just having another hissy fit

The CI is revamped in #207 , so merging that will probably resolve these issues, anyway. Let's just wait until that's merged before trying to merge this

Sounds good to me, I'll approve anyway so you can merge when ready.