CATIA-Systems / FMPy

Simulate Functional Mockup Units (FMUs) in Python
Other
429 stars 118 forks source link

error: format not a string literal and no format arguments #619

Open jschueller opened 11 months ago

jschueller commented 11 months ago

the printf/fprintf format argument is missing in several places:

diff --git a/src/modelica/ModelicaFMI.c b/src/modelica/ModelicaFMI.c
index a74cd73..a1fca6d 100644
--- a/src/modelica/ModelicaFMI.c
+++ b/src/modelica/ModelicaFMI.c
@@ -48,7 +48,7 @@ static void logFunctionCall(FMIInstance* instance, FMIStatus status, const char*
     if (logFile) {
         fprintf(logFile, "[%s] ", instance->name);
         vfprintf(logFile, message, args);
-        fprintf(logFile, suffix);
+        fprintf(logFile, "[%s] ", suffix);
     } else {
         ModelicaFormatMessage("[%s] ", instance->name);
         ModelicaVFormatMessage(message, args);
diff --git a/src/modelica/ModelicaUtilities.c b/src/modelica/ModelicaUtilities.c
index ca5bd71..7365f39 100644
--- a/src/modelica/ModelicaUtilities.c
+++ b/src/modelica/ModelicaUtilities.c
@@ -20,7 +20,7 @@ void ModelicaMessage(const char *string) {
        if (s_callbacks.ModelicaMessage) {
                s_callbacks.ModelicaMessage(string);
        } else {
-               printf(string);
+               printf("%s", string);
        }
 }

@@ -52,7 +52,7 @@ void ModelicaError(const char *string) {
        if (s_callbacks.ModelicaError) {
                s_callbacks.ModelicaError(string);
        } else {
-               printf(string);
+               printf("%s", string);
        }
 }

fprintf.patch.txt