search

CATcher-org / CATcher

CATcher is a software application used for peer-testing of software projects.
https://catcher-org.github.io/CATcher/
MIT License
70 stars 68 forks source link

Migrate bug reporting phase to playwright #1186

Closed cheehongw closed 1 year ago

cheehongw commented 1 year ago

Summary:

Completes the migration set out in #1111

This PR branches off #1185, and should be merged after #1185

Changes Made:

Proposed Commit Message:

Migrate bug reporting phase e2e test to Playwright

Let's
- Migrate `bugReportingPhase.e2e-spec.ts` to Playwright's 
`bugReportingPhase.spec.ts`
- Remove protractor from CATcher
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03 :tada:

Comparison is base (ffae1f1) 54.60% compared to head (219da6a) 54.63%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1186 +/- ## ========================================== + Coverage 54.60% 54.63% +0.03% ========================================== Files 101 101 Lines 2888 2888 Branches 535 535 ========================================== + Hits 1577 1578 +1 Misses 967 967 + Partials 344 343 -1 ``` [see 1 file with indirect coverage changes](https://codecov.io/gh/CATcher-org/CATcher/pull/1186/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

chunweii commented 1 year ago

@cheehongw Sorry for the late reply, but I would like you to make a few more changes.

cheehongw commented 1 year ago

@cheehongw Sorry for the late reply, but I would like you to make a few more changes.

  • There are currently 2 login.spec.ts files. Please remove the file that is not in use.
  • webdriver-manager is used by Protractor but not Playwright. Please remove it from package.json.

Thanks @chunweii, I will push this changes in a new PR