search

CATcher-org / CATcher

CATcher is a software application used for peer-testing of software projects.
https://catcher-org.github.io/CATcher/
MIT License
70 stars 68 forks source link

Upgrade to Angular 11 #1203

Closed cheehongw closed 1 year ago

cheehongw commented 1 year ago

Summary:

Fixes #711 This pull request addresses some of the outdated packages in our application.

Changes Made:

Proposed Commit Message:

Upgrade to Angular 11

Some of our packages are old and outdated. We should actively maintain 
and keep these packages up-to-date so it is easier to maintain in the 
future.

Let's upgrade to Angular 11 to keep our packages up-to-date.
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03% :tada:

Comparison is base (c107340) 53.93% compared to head (7a4a36e) 53.97%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1203 +/- ## ========================================== + Coverage 53.93% 53.97% +0.03% ========================================== Files 101 101 Lines 2881 2881 Branches 534 534 ========================================== + Hits 1554 1555 +1 Misses 984 984 + Partials 343 342 -1 ``` | [Files Changed](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org) | Coverage Δ | | |---|---|---| | [src/app/core/services/github.service.ts](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org#diff-c3JjL2FwcC9jb3JlL3NlcnZpY2VzL2dpdGh1Yi5zZXJ2aWNlLnRz) | `15.60% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1203/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cheehongw commented 1 year ago

@CATcher-org/developers This is ready for testing. Please mention your OS/browser in your review as well. Thanks!

gycgabriel commented 1 year ago

System

OS: Windows 11 Home Build 22621.1992 Browser: Google Chrome Browser Version: Version 114.0.5735.199 (Official Build) (64-bit) Local Angular Version: 11.2.19

Actions Run

npm install: success npm run ng:serve:web

Tested Phases

  1. Bug Reporting Phase
  2. Team's Response Phase
  3. Tester's Response Phase (Team Disagree response)

I couldn't get the format right for the accepted Team Response to test for Tester's Response Phase, I think it changed since I last used it.

No bugs found

cheehongw commented 1 year ago

what is the format that you used for accepted Team Response for Tester's Response Phase? Can you share the markdown?

@gycgabriel

gycgabriel commented 1 year ago

what is the format that you used for accepted Team Response for Tester's Response Phase? Can you share the markdown?

@gycgabriel

I used 

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

# Team's Response
Accepted

Your response is not required for this bug as the team has accepted the bug as it is.

<catcher-end-of-segment><hr>

I'm not sure what should be the proper format

The example issue itself is here: https://github.com/gycgabriel/bugreporting/issues/17

luminousleek commented 1 year ago

@gycgabriel Looks like the proper format is just

Your response not required for this bug as the team has accepted the bug as it is.

I think that's what Prof Damith's PE script automatically adds. See luminousleek/pe#19 as an example. Don't think it's changed since the last time we used it - the most recent commit for the teamAcceptedParser was written by me last year heh

luminousleek commented 1 year ago

System

OS: macOS Ventura 13.5 Browser: Safari Browser Version: Version 16.6 (18615.3.12.11.2) Local Angular Version: 11.2.19

Actions Run

npm install: success npm run ng:serve:web

Tested Phases

  1. Bug Reporting Phase
  2. Team's Response Phase
  3. Tester's Response Phase (Team Disagree response)

No bugs found