CATcher-org / CATcher

CATcher is a software application used for peer-testing of software projects.
https://catcher-org.github.io/CATcher/
MIT License
70 stars 68 forks source link

Save pageSize setting into sessionStorage #1207

Closed LJXSean closed 1 year ago

LJXSean commented 1 year ago

Summary:

Fixes #1051

Changes Made:

Demo

CATcher-Issue1051

Proposed Commit Message:

Add attribute directive to mat-paginator

The selected items per page setting for each issue table is lost 
after navigation to a different page or on refresh.

Caching this setting is more user-friendly because users do 
not need to re-input the same page settings.

Let's save this setting to session storage using an attribute directive.
codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (6b092b1) 53.97% compared to head (7130730) 53.97%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1207 +/- ## ======================================= Coverage 53.97% 53.97% ======================================= Files 101 101 Lines 2881 2881 Branches 534 534 ======================================= Hits 1555 1555 Misses 984 984 Partials 342 342 ``` | [Files Changed](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org) | Coverage Δ | | |---|---|---| | [.../app/shared/issue-tables/issue-tables.component.ts](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org#diff-c3JjL2FwcC9zaGFyZWQvaXNzdWUtdGFibGVzL2lzc3VlLXRhYmxlcy5jb21wb25lbnQudHM=) | `14.13% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.