Remove unauth GitHub api

chunweii commented 1 year ago

Summary:

Fixes #1220

Changes Made:

Use the unauthenticated REST API to fetch the settings first, and only fall back to using raw.githubusercontent.com if the REST API fails.
To test it out you can run the following bash command on your computer to hit the rate limit of 60 for i in {1..60}; do curl https://api.github.com/repos/CATcher-org/public_data/contents/settings.json; done;

Proposed Commit Message:

Use rest api first, then raw githubusercontent

REST API should be more reliable, but it has a rate limit
for unauthenticated requests. Let's use REST API call for
the fetching of settings.json, with a failsafe being
raw.githubusercontent.com.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e8cab15) 53.95% compared to head (636350b) 53.83%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1221 +/- ## ========================================== - Coverage 53.95% 53.83% -0.13% ========================================== Files 101 101 Lines 2882 2885 +3 Branches 534 534 ========================================== - Hits 1555 1553 -2 - Misses 985 988 +3 - Partials 342 344 +2 ``` | [Files](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org) | Coverage Δ | | |---|---|---| | [src/app/core/services/github.service.ts](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org#diff-c3JjL2FwcC9jb3JlL3NlcnZpY2VzL2dpdGh1Yi5zZXJ2aWNlLnRz) | `15.17% <ø> (-0.33%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/CATcher-org/CATcher/pull/1221/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CATcher-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

damithc commented 1 year ago

@CATcher-org/active-devs shall we get this PR merged quickly, while students are still smoke testing CATcher?

CATcher-org / CATcher