search

CATcher-org / CATcher

CATcher is a software application used for peer-testing of software projects.
https://catcher-org.github.io/CATcher/
MIT License
71 stars 66 forks source link

Fix broken duplicate link #1233

Closed nknguyenhc closed 5 months ago

nknguyenhc commented 6 months ago

Summary:

Fixes CATcher-org/CATcher#1228

Changes Made:

I made the link work as expected.

Originally, the anchor tag appends the issue ID to the path. Hence the link from issue 1 to issue 2 looks like <phase>/issues/1/2, but it should be something like <phase>/issues/2. The link in the anchor tag now yields the correct path to the duplicate issue.

There are two places that this component is used, both of which I have (manually) tested:

  1. Issue view (responded)
  2. New team response

Proposed Commit Message:

Fix the broken link of a duplicate issue

Currently, the user cannot open the link to a duplicate issue
when opening an issue, as described in CATcher-org/CATcher#1228.

The links now work as expected.
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (013fbfa) 53.86% compared to head (0f9d5ff) 53.89%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1233 +/- ## ========================================== + Coverage 53.86% 53.89% +0.03% ========================================== Files 101 101 Lines 2885 2885 Branches 534 534 ========================================== + Hits 1554 1555 +1 Misses 988 988 + Partials 343 342 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nknguyenhc commented 5 months ago

@damithc @CATcher-org/2324s2 Any update on this PR :) ?