Closed nknguyenhc closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2c18b71
) 53.41% compared to head (3c4af54
) 53.44%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also, I think you can explore upgrading our ngx-markdown version to enable gfmd as you mentioned in #1230
Actually I realised that ngx-markdown documentation was actually outdated/incorrect. Also, GFMD was already enabled in CATcher, so right now the current ngx-markdown version is sufficient. We probably can explore upgrading ngx-markdown version when we upgrade the packages/angular/node version.
Summary:
Fixes #1230
Changes Made:
breaks
option in the app module markdown declaration.Note that in #1230, the subset list is not exactly rendered as a list, but is rendered with linebreaks.
Github preserves linebreaks when rendering markdown, hence it looks like the items are rendered as list items.
One consequence of this PR is that, whenever two sentences are separated only by one line break, in html, instead of the two being one paragraph (as expected from standard markdown syntax), the two are preserved and rendered as two paragraphs (as expected behaviour of github markdown).
Summarising everything in one example, the following markdown code:
is rendered as:
Proposed Commit Message: