Angular 12

[cheehongw]

Summary:

This pull request addresses some of the outdated packages in our application.

Changes Made:

• Upgrade to Angular 12 using ng update

  • See: https://update.angular.io/?l=3&v=11.0-12.0
  • All the items in the above link were reviewed and it doesn't seem we are affected by any of the changes. These are:
  • If you extend the HttpParams class you may have to update the signature of its method to reflect changes in the parameter types.
  • If you use Angular forms, min and max attributes on will now trigger validation logic.
  • If your app has custom classes that extend FormArray or FormGroup classes and override the above-mentioned methods, you may need to update your implementation
  • routerLinkActiveOptions property of RouterLinkActive now has a more specific type. You may need to update code accessing this property to align with the changes.
  • The initializer callbacks now have more specific return types, which may require update of your code if you are getting an APP_INITIALIZER instance via Injector.get or TestBed.inject.
  • The router fragments now could be null. Add null checks to avoid TypeScript failing with type errors.
  • Make sure you don't rely on ng.getDirectives throwing an error if it can't find a directive associated with a particular DOM node.
  • This item was skipped:

    You can run the optional migration for enabling production builds by default ng update @angular/cli@12 --migrate-only production-by-default.

• Update dependency ngx-markdown@12.0.1 (from @11.2.0) to support angular 12

• Update dependency ts-node@^10.9.2 from @^7.0.1

  • The cosmiconfig-typescript-loader library used by graphQL-codegen requires ts-node v10 as peer-dependency. Since no other libraries depend on ts-node, this upgrade should be safe to perform.

• Freeze dependency @graphql-codegen/cli@2.16.4 from ^2.6.4

  • The latest major version of this dependency is 2.16.5, which sets cosmiconfig-typescript-loader@^4.3.0 as dependency. The latest major version (4.4.0) of cosmiconfig-typescript-loader only supports Node v14.21.3 and above

Proposed Commit Message:

Upgrade to Angular 12

Some of our packages are old and outdated. We should actively maintain 
and keep these packages up-to-date so it is easier to maintain in the 
future.

Let's upgrade to Angular 12 to keep our packages up-to-date.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a1b5000) 53.13% compared to head (070732e) 54.77%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1242 +/- ## ========================================== + Coverage 53.13% 54.77% +1.63% ========================================== Files 105 105 Lines 2951 2859 -92 Branches 549 503 -46 ========================================== - Hits 1568 1566 -2 Misses 1030 1030 + Partials 353 263 -90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[cheehongw]

Kindly provide your Node, npm and OS version, when you test this PR.

[luminousleek]

System

OS: macOS Ventura 13.6.3 Browser: Safari Browser Version: Version 16.6 (18615.3.12.11.2) Local Angular Version: 12.2.18

Actions Run

npm install: success npm run ng:serve:web

Tested Phases

1. Bug Reporting Phase
2. Team's Response Phase
3. Tester's Response Phase (Team Disagree response)

No bugs found

[chunweii]

System

OS: Windows 11 22H2 Browser: Chrome Browser Version: Version 121.0.6167.161 (Official Build) (64-bit) Local Angular Version: 12.2.18

Actions Run

npm install: success npm run ng:serve:web

Tested Phases

1. Bug Reporting Phase
2. Team's Response Phase
3. Tester's Response Phase

No bugs found

[cheehongw]

System

OS: ubuntu 22.04 Browser: chrome Browser Version: Version 114.0.5735.133 (Official Build) (64-bit) Local Angular Version: 12.2.18 node version: 14.21.2 npm version: 6.14.17

Actions Run

npm install: success npm run ng:serve:web npm run test npm run e2e

Tested Phases

1. Bug Reporting Phase
2. Team's Response Phase
3. Tester's Response Phase (Team Disagree response)

No bugs found