CATcher-org / CATcher

CATcher is a software application used for peer-testing of software projects.
https://catcher-org.github.io/CATcher/
MIT License
71 stars 66 forks source link

Faulty list view when back navigating #1243

Closed Arif-Khalid closed 4 months ago

Arif-Khalid commented 4 months ago

Summary:

Fixes #1227

Changes Made:

Proposed Commit Message:

Issue table settings such as page index are not 
saved when table is re-mounted.

This behavior inconveniences users as their settings 
are reset everytime they navigate to a specific issue and back.

Let's lift up the table settings of each mounted table to 
a service which the tables pull from when mounted.
codecov-commenter commented 4 months ago

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (a9d38dd) 53.44% compared to head (63ddff1) 53.10%.

Files Patch % Lines
.../app/shared/issue-tables/issue-tables.component.ts 15.38% 8 Missing and 3 partials :warning:
.../app/core/services/issue-table-settings.service.ts 27.27% 4 Missing and 4 partials :warning:
src/app/core/models/table-settings.model.ts 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1243 +/- ## ========================================== - Coverage 53.44% 53.10% -0.35% ========================================== Files 103 105 +2 Lines 2928 2951 +23 Branches 544 549 +5 ========================================== + Hits 1565 1567 +2 - Misses 1014 1030 +16 - Partials 349 354 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.