Migrate from TSLint to ESLint

CATcher-org / CATcher

CATcher is a software application used for peer-testing of software projects.

https://catcher-org.github.io/CATcher/

MIT License

71 stars 66 forks source link

Migrate from TSLint to ESLint #1250

Closed MadLamprey closed 2 months ago

MadLamprey commented 4 months ago

Summary:

Fixes #1247

Changes Made:

Migrate to ESLint from TSLint
- See: https://github.com/angular-eslint/angular-eslint/blob/main/docs/MIGRATING_FROM_TSLINT.md
- All changes mentioned have been reviewed
- Each rule mentioned in `tslint.json` has been reviewed and its ESLint counterpart has been defined in `.eslintrc.json`.
- There are a few rules that have not been mapped due to huge changes to the codebase or errors produced as a result of the translation. These include:
  - `deprecation/depreciation`
  - `prefer-const`
  - `dot-notation`
  - `import-spacing`
- Few changes have been made to prevent errors that were not earlier raised with the TSLint configuration

### Proposed Commit Message: ``` Migrate to ESLint TSLint is now deprecated in favour of ESLint. We should keep our dependencies up-to-date. Let's migrate to ESLint to ensure that our linter is up-to-date. ```

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.27%. Comparing base (e319865) to head (44dc8eb). Report is 9 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1250 +/- ## ========================================== + Coverage 54.84% 58.27% +3.43% ========================================== Files 105 105 Lines 2859 2598 -261 Branches 503 291 -212 ========================================== - Hits 1568 1514 -54 - Misses 1030 1033 +3 + Partials 261 51 -210 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cheehongw commented 2 months ago

For some unknown reason, the arrow-body-style keeps failing CI at 2 specific lines even though it passes linting locally.

One of the instances is below, in issue.service.ts. The first function body passes the lint check on github CI, but the one on the bottom doesn't, even though they are exactly the same.