Closed nknguyenhc closed 5 months ago
Attention: Patch coverage is 9.09091%
with 10 lines
in your changes are missing coverage. Please review.
Project coverage is 54.62%. Comparing base (
5e7ed48
) to head (951e632
).
Files | Patch % | Lines |
---|---|---|
src/app/core/services/auth.service.ts | 9.09% | 9 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Using an invalid URL (e.g. linking to an issue that doesn't exist) should redirect to the default landing page, but currently displays a blank page.
Using an invalid URL (e.g. linking to an issue that doesn't exist) should redirect to the default landing page, but currently displays a blank page.
Fixed! In ViewIssueComponent::getAndPollIssue
, I redirect to current phase landing page if there is error polling the issue.
Fixed! In
ViewIssueComponent::getAndPollIssue
, I redirect to current phase landing page if there is error polling the issue.
Cool, is it possible to have an error popup when this happens?
Summary:
Fixes #1229
Changes Made:
Unlike CATcher-org/WATcher#255,
Note that it only redirects to the current phase. If there are multiple open phases, the app only allows redirection to the "current phase", which is the first available phase. However, given that in CATcher, only one phase is allowed at a time,
Proposed Commit Message: