CATcher-org / WATcher

WATcher is a sister application to CATcher to be used to monitor software projects.
https://catcher-org.github.io/WATcher/
7 stars 25 forks source link

Fix top and bottom shadow of columns #357

Closed Arif-Khalid closed 5 months ago

Arif-Khalid commented 6 months ago

Summary:

Fixes #354 Fixes #353

Type of change:

Changes Made:

Screenshots:

Before the change image image After the change image image

Proposed Commit Message:

A few bugs exist related to column shadows. 
Top shadow is shown when there are no elements
behind header and hidden when there are.
Bottom shadow sticks to the column as a user scrolls.

These are not the intended behaviour of the shadows
to indicate presence of elements behind above or
below columns respectively.

Let's update the CSS to correspond to
appropriate shadow behaviours.

Checklist:

- [x] I have tested my changes thoroughly. - [ ] I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this. - [x] I have added or modified code comments to improve code readability where necessary. - [ ] I have updated the project's documentation as necessary.
damithc commented 6 months ago

@Arif-Khalid This is clearly a bug. So, let's write the commit message from that perspective. The current one sounds like we are tweaking the design, not fixing a bug. Also, refactoring should not change behavior. So, this should not be called a refactoring.

Example:

Prevent bottom shadow from sticking to column
---------------------------------------------------
The shadow at the bottom of a column sticks to the column content
as the column is scrolled.

Let's fix this bug so that the shadow stays in place during scrolling.
Arif-Khalid commented 6 months ago

@Arif-Khalid This is clearly a bug. So, let's write the commit message from that perspective. The current one sounds like we are tweaking the design, not fixing a bug. Also, refactoring should not change behavior. So, this should not be called a refactoring.

Example:

Prevent bottom shadow from sticking to column
---------------------------------------------------
The shadow at the bottom of a column sticks to the column content
as the column is scrolled.

Let's fix this bug so that the shadow stays in place during scrolling.

Understood. I have updated my PRs appropriately.