Closed Arif-Khalid closed 5 months ago
@Arif-Khalid This is clearly a bug. So, let's write the commit message from that perspective. The current one sounds like we are tweaking the design, not fixing a bug. Also, refactoring should not change behavior. So, this should not be called a refactoring.
Example:
Prevent bottom shadow from sticking to column
---------------------------------------------------
The shadow at the bottom of a column sticks to the column content
as the column is scrolled.
Let's fix this bug so that the shadow stays in place during scrolling.
@Arif-Khalid This is clearly a bug. So, let's write the commit message from that perspective. The current one sounds like we are tweaking the design, not fixing a bug. Also, refactoring should not change behavior. So, this should not be called a refactoring.
Example:
Prevent bottom shadow from sticking to column --------------------------------------------------- The shadow at the bottom of a column sticks to the column content as the column is scrolled. Let's fix this bug so that the shadow stays in place during scrolling.
Understood. I have updated my PRs appropriately.
Summary:
Fixes #354 Fixes #353
Type of change:
Changes Made:
Screenshots:
Before the change After the change
Proposed Commit Message:
Checklist: