Open JiaXinEu opened 2 months ago
I see the vision and am open to the possibility of using a scrollable filters container like you have implemented. However, I feel that the scrollbar is not very intuitive to the user, i.e., not what you would find on most other sites. It will also be quite hard to use on a small screen like a mobile screen compared to a hamburger or dropdown menu, which is the very audience this change is supposed to cater to. I would prefer a different approach but you are free to continue working on this approach and try to apply some cosideration for mobile users who don't have that much space to scroll horizontally for example left and right scroll buttons at the ends of the scrollbar.
Thank you for a better insight of the issue. The current PR uses a togglable menu approach
Additionally, would it be better to put the app-label-filters into the hamburger dropdown as well since on small screens at first glance it now seems to suggest it denotes something about all filters.
Thank you for the feedback. I have moved label-filter into the hamburger dropdown as well, and done the minor fixes on css as suggested.
Summary:
Fixes #377
Type of change:
Changes Made:
BreakpointObserver
to observe and respond to screen size changesfilter-bar
dropdown-filters
in scrollable containerScreenshots:
Proposed Commit Message:
Checklist: