search

CATechnologiesTest / yipee

An opensource version of the Yipee.io editor.
Apache License 2.0
22 stars 12 forks source link

Service selectors and generated labels have "yipee.io" instead of "yipee" in the name #8

Closed markemeis closed 5 years ago

markemeis commented 6 years ago

When connecting a service to a container group, it adds labels to the container group named "yipee.io/". The name of the label should be "yipee/"

jlegrone commented 6 years ago

Hey just stopping by, this looks like a cool project! Please let me know if I'm misunderstanding this issue, but the Kubernetes docs recommend valid subdomains as label prefixes. It would be ideal if this tool followed that convention.

Reference: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set

If specified, the prefix must be a DNS subdomain: a series of DNS labels separated by dots (.), not longer than 253 characters in total, followed by a slash (/).

jd3quist commented 5 years ago

Thanks jlegrone (and sorry for the slow response). You're absolutely right about the label prefixes. We'll leave them as "yipee.io".