search

CAVEconnectome / CAVEclient

This is the python client for accessing REST APIs within the Connectome Annotation Versioning Engine.
https://caveconnectome.github.io/CAVEclient/
MIT License
21 stars 11 forks source link

L2 cache JSON encoder #52

Closed ceesem closed 3 years ago

ceesem commented 3 years ago

Various clients all have to have numpy encoders for the json dumps, however they all seem to be copy/paste. This adds a generic one to .base and uses it for the l2client.

Is there any reason to not move all of the other encoders to the same common one? I don't see any custom logic in any of them right now.

fcollman commented 3 years ago

agreed.. lets extend this pattern to all of them.

sdorkenw commented 3 years ago

Agreed. I don't see a difference between them either.