search

CAVEconnectome / CAVEclient

This is the python client for accessing REST APIs within the Connectome Annotation Versioning Engine.
https://caveconnectome.github.io/CAVEclient/
MIT License
19 stars 12 forks source link

Reference merge #70

Closed fcollman closed 2 years ago

fcollman commented 2 years ago

adds a flag to allow automatic merging of reference annotations.

Choices made.. automatically add a "ref" suffix to the reference table columns that overlap (this will make the reference table id "id_ref" in the dataframe).

Make this default True: This means metadata needs to be queried for every table even if not a reference, but i've enabled caching of this information now so it should be a one time cost per session-table.

Haven't addressed join query as it would be more complicated.

ceesem commented 2 years ago

The id and valid fields from a merged table come back with an underscore: id_ and valid_. However, I think this is actually an error on the server side, including the underscore in the suffix even if it is has zero length. Otherwise, looks good to me.

ceesem commented 2 years ago

Also, I modified the assemble_attrs code a bit to better handle joins implicitly done during query_table.