Closed ceesem closed 5 years ago
Merging #24 into master will increase coverage by
1.38%
. The diff coverage is93.67%
.
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
+ Coverage 74.71% 76.1% +1.38%
=========================================
Files 11 11
Lines 1677 1695 +18
=========================================
+ Hits 1253 1290 +37
+ Misses 424 405 -19
Impacted Files | Coverage Δ | |
---|---|---|
meshparty/skeleton_io.py | 89.15% <100%> (ø) |
:arrow_up: |
meshparty/trimesh_io.py | 74.82% <100%> (+0.11%) |
:arrow_up: |
meshparty/trimesh_vtk.py | 79.92% <20%> (-1.15%) |
:arrow_down: |
meshparty/skeleton.py | 96.15% <97.82%> (+11.77%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 995e169...b68f598. Read the comment docs.
need tests for the new functionality
looks good to me!
Two improvements.
1) Mesh masking uses a trimesh-native approach that significantly speeds up the mask-based reindexing. 2) Exposes/allows a few new features of the skeleton graph, such as snipping graphs at a point, parent and child node look-ups, and better nomenclature for sets of covering paths. These are useful for other skeleton computations.
This does have a small breaking change in the order of arguments to trimesh_vtk.linked_point_actor, which no longer needs indices.