search

CAVEconnectome / MeshParty

Apache License 2.0
35 stars 16 forks source link

perf: use CloudVolume multithreaded mesh download #41

Closed william-silversmith closed 5 years ago

william-silversmith commented 5 years ago

My local test using time python -m pytest -v test -x -k download_meshes is about 22-23 sec for existing, 16-17sec for this version.

william-silversmith commented 5 years ago

Resolves #40

codecov-io commented 5 years ago

Codecov Report

Merging #41 into master will increase coverage by 0.08%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   76.43%   76.52%   +0.08%     
==========================================
  Files          12       12              
  Lines        1710     1708       -2     
==========================================
  Hits         1307     1307              
+ Misses        403      401       -2
Impacted Files Coverage Δ
meshparty/trimesh_io.py 74.76% <85.71%> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1aa1d2...f4ff8d7. Read the comment docs.

william-silversmith commented 5 years ago

This might not actually make as big of a difference as I thought.