CAVEconnectome / MeshParty

Apache License 2.0
35 stars 16 forks source link

Vtk scale bars #44

Closed fcollman closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #44 into master will increase coverage by 1.42%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   76.65%   78.08%   +1.42%     
==========================================
  Files          12       12              
  Lines        1718     1862     +144     
==========================================
+ Hits         1317     1454     +137     
- Misses        401      408       +7
Impacted Files Coverage Δ
meshparty/trimesh_vtk.py 81.06% <100%> (+1.13%) :arrow_up:
meshparty/skeleton.py 95.52% <0%> (-0.64%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 641e319...cf7e11f. Read the comment docs.

ceesem commented 5 years ago

Looks good to me. Do you think it'd be worth putting a comment or two into the code about some of the more obscure vtk functions (e.g. SetFlyModeToNone) for looking back on in the future?