CAVaccineInventory / site

Home of the static site
https://vaccinateCA.com
MIT License
1 stars 0 forks source link

Remove eligibility from map info card #896

Closed khaister closed 3 years ago

khaister commented 3 years ago

Resolves #894

Currently only filter out age eligibility but I can refactor this a bit to add more things to filter out. I assume that these values (to be filtered) come from https://docs.vaccinateca.com/reference#availability-info API.

Link to Deploy Preview: https://deploy-preview-896--vaccinateca.netlify.app/


Manual Testing (QA)

(Note: Use your best judgement for time management. If this PR is a minor content adjustment, you might not invest in the full list of QA checks below. But for medium-large PRs, we recommend a thorough review.)

Open the deploy preview and manually perform the following tests with the browser's developer console open. Fix or log any unexpected errors you see in the console. Check off the following manual tests as you go through them. Make sure to resize the screen and check for poorly positioned or spaced items at mobile and tablet sizes (60%+ of our audience is on mobile devices).

Homepage

/near-me

County Vaccination Site List page

County Policies page

Other pages

Did you remember to:

alexcole commented 3 years ago

Yay! Looks like the eligibility info on the main list currently just does a few specific checks for restrictions (https://github.com/CAVaccineInventory/site/blob/main/webpack/sites.js#L111). I wonder if we should just do the same ones for the map cards (or share code)? But I'll let other people who know more chime in.

dolliars commented 3 years ago

Question for this: in the PR #786 we removed notes specifying :

And left the notes pertaining to :

My question is: should we do the same here?

If we look at the screenshots below, only the age is removed as mentioned in the PR. But maybe some of the other stuff should be removed also?

Screenshot of Live

Screen Shot 2021-04-19 at 21 30 56

Screenshot of the changes in this PR

Screen Shot 2021-04-19 at 21 30 47
khaister commented 3 years ago

After: image

Before: image