search

CAVaccineInventory / site

Home of the static site
https://vaccinateCA.com
MIT License
1 stars 0 forks source link

Redirect everything to VTS #934

Closed skalnik closed 3 years ago

skalnik commented 3 years ago

This PR just does a blanket redirect to VTS as we shut things down

Link to Deploy Preview: https://deploy-preview-934--vaccinateca.netlify.app/

skalnik commented 3 years ago

It looks to me like this will be non-(significantly)-breaking for the hardcoded re-direct logic from #927, but could you confirm that you agree?

Yeah the embed would break. I think at this point it may be ok to do that vs having stale embeds?

obra commented 3 years ago

Since there are still counties who haven't even been notified of the shutdown linking to the old embed (which currently redirs to the new embed), could we at least not break that? If we can't, we can't.

eliblock commented 3 years ago

I phrased that comment confusingly - thank you for seeing through that.

(edit: See @obra's comment above) I am not sure how the embeds are currently used from this site (vs. vaccinatethestates).

Is it maybe worth redirecting everything but /embed (or maybe /embed, es/embed, etc.), and allowing the script-driven redirect to continue to work for /embed? This seems doable - if hack-y - by simply listing our (small) set of routes.

skalnik commented 3 years ago

Anything is possible, so we can absolutely do that! That being said, I think we should be prioritizing reaching out to them and then actively breaking this embed, rather than serving stale (and thus time wasting/demoralizing) data.