CAWSCIT / ca-meeting-finder-issue-tracker

Public Repo For tracking known issues and work for the C.A. Meeting Finder app.
0 stars 0 forks source link

Validate virtual location is a url #40

Open enderv opened 1 month ago

enderv commented 1 month ago

Is your feature request related to a problem? Please describe. tsml expects conference url to be valid urls but in the admin API users can enter any text.

Is this related to the mobile app or meeting entry Meeting entry

Describe the solution you'd like We should validate on input and possibly validate on GET and remove invalid entries

Additional context if invalid url is entered tsml-ui just shows typeError: cannot read properties of undefined

KalobTaulien commented 1 month ago

URLs are validated upon saving now https://github.com/CAWSCIT/caws-api/commit/a21e77a067eff7a94ff1be027a2f2d94ac2bd5c1

I'll work on updating TSML to check if incoming conference URL's are valid URLs.

KalobTaulien commented 1 month ago

PR opened to validate TSML Plugin URLs https://github.com/CAWSCIT/caws-api/pull/141