search

CAYdenberg / hypocube

Composable, responsive, React-based data visualization
https://hypocube.livingpixel.io
MIT License
0 stars 1 forks source link

Series offset strategy needs a bit of thought #40

Closed CAYdenberg closed 3 years ago

CAYdenberg commented 3 years ago

The problem with using dataBoxLeftOffset and dataBoxThickness is that it isn't totally apparent what the offset should be for non-databox point: ie whiskers and anchors. As it stands, the whisker caps are centered based on their own length, and the midline of the whiskers is not offset at all, which is clearly a bug. A further limitation is that the offset cannot be different from the bar thickness (creating a gap or overlap, if that is desired).

CAYdenberg commented 3 years ago

Idea: replace dataBoxLeftOffset with seriesXOffset that shifts the whole data series either left or right. Normally this would have the same value (or the same function) as dataBoxThickness.

applySeriesStyles needs to change to deal in absolutes instead of multiples of dataBoxOffset.