CBATeam / CBA_A3

Community Base Addons for Arma 3
https://github.com/CBATeam/CBA_A3/wiki
GNU General Public License v2.0
367 stars 150 forks source link

HEMTT vs Mikero Release Build Diffs #1316

Closed PabstMirror closed 8 months ago

PabstMirror commented 4 years ago

most cfgPatches Hemmt0.8/MikroLastFree

onLoad = " params ['_ctrlYear']; for '_y' from 1900 to 2050 do { _ctrlYear lbSetValue [_ctrlYear lbAdd str _y, _y]; }; _ctrlYear lbSetCurSel 53; ";


- disposable/jam
mikro adds `magazines[] = {};` (maybe because they touch `class cfgMags`)

- ee major diff (mikro is using nobin so it's raw non-demacroed code) can probably ignore

- events (causes bug - thanks to @Dystopian for spotting this)

onKeyDown = " if ((_this select 1) in [0x1C , 0x9C ]) then { ['cba_events_chatMessageSent', [ctrlText ((_this select 0) displayctrl 101), _this select 0]] call CBA_fnc_localEvent; }; false\";

onKeyDown = "if ((_this select 1) in [0x1C,0x9C]) then { ['cba_events_chatMessageSent', [ctrlText ((_this select 0) displayctrl 101),_this select 0]] call CBA_fnc_localEvent; }; false";

- main_a3/config,cpp CfgMods
`       name = "Community Base Addons v0.0.0";`

- cba_optic_big_100.p3d Binary Files Differ (but can probably ignore)

- ui - looks like bug

idc = "__EVAL(12000 + 023)"; idc = 12023;

jonpas commented 4 years ago

Most CfgPatches

Issue with my version setting stuff. I'll check it again.

Mikro adds weapons[] = {}; if not defined (is this required by arma?)

It's not, but it doesn't matter, in ACE3 it's in the template anyways, but it's not required.

mikro adds magazines[] = {}; (maybe because they touch class cfgMags)

Same as weapons[] = {};.

ee major diff (mikro is using nobin so it's raw non-demacroed code) can probably ignore

It shouldn't be necessary at all with HEMTT, I have it in the TODO list on the closed HEMTT PR (revert #1199).

events (causes bug - thanks to @Dystopian for spotting this)

Is the escaped quote at the end the problem? That's the only difference I see.

main_a3/config,cpp CfgMods

Same as CfgPatches stuff, my issue, will look into it.

cba_optic_big_100.p3d Binary Files Differ (but can probably ignore)

I believe files added by Mikero are useless. But if they improve something, it should be looked into.

ui - looks like bug

:+1:


@synixebrett tagging you to look at above issues for your new preprocessor. :)

dedmen commented 4 years ago

Is the escaped quote at the end the problem? That's the only difference I see.

Yes syntax error

Dystopian commented 4 years ago
jonpas commented 4 years ago

Same issue as the other one. Good find. :+1:

Dystopian commented 4 years ago

Mikro adds weapons[] = {}; if not defined (is this required by arma?)

It's not, but it doesn't matter, in ACE3 it's in the template anyways, but it's not required.

Looks like Zeus when loading requires units and weapons config arrays (not really sure about weapons but there is scanning in code for both arrays). If there are no these arrays you get error in game and RPT: Warning Message: No entry 'config.bin/CfgPatches/addon_name_here.units'.

commy2 commented 4 years ago

That's not Zeus. The game always required units[], but never weapons[].

jonpas commented 8 months ago

Releases are built with HEMTT exclusively now.