Open simonbray opened 1 year ago
Sorry about that, the solvation seems deterministic in PDBFixer (https://github.com/openmm/pdbfixer/blob/db2886903fe835919695c465fd20a9ae3b2a03cd/pdbfixer/pdbfixer.py#L1051) and there's no seed argument in the function either.
@AlvaroSmorras when I try to run the same command twice, the positions of the water molecules recorded in the inpcrd file are different. So I assume it cannot be deterministic. But I admit, I don't see anything in that code which suggests randomness. 😕
@AlvaroSmorras when I try to run the same command twice, the positions of the water molecules recorded in the inpcrd file are different. So I assume it cannot be deterministic. But I admit, I don't see anything in that code which suggests randomness. confused
Hmh... the PDBFixer uses the openmm.app Modeller class with the addSolvent function. But it does not have any seed option either. I added the seed option for the equilibration,Md and SMDs, however.
Comment from @PatriciaBlanco, sort the report table by the system name. It can be easily done by sorting the output df here: https://github.com/CBDD/openduck/blob/14767e5c46d7800b337a36f8be60351090be9f1c/duck/utils/analysis_and_report.py#L118C12-L118C14
Suggestions from the meeting today:
ping @AlvaroSmorras @DAlvGar @xbarril