CBHSQ / findtreatment

FindTreatment.gov, An 18F+SAMHSA Collaboration
https://findtreatment.gov/
Other
19 stars 12 forks source link

Home page linking issue - first "learn more" button #488

Closed bpdesigns closed 5 years ago

bpdesigns commented 5 years ago

tested on iPhone 7

Current state

Desired state

allisonnorman commented 5 years ago

@bpdesigns - Weird, I can't reproduce on my iPhone X. Any chance you could try to screengrab this so we can debug?

bpdesigns commented 5 years ago

@allisonnorman link to video of it happening. Maybe its a screen size issue?

allisonnorman commented 5 years ago

Thank you! I'm able to reproduce it in Chrome for iPhone 6/7/8 Plus. This definitely seems like a bug. @davemcorwin - Can you take a look?

davemcorwin commented 5 years ago

huh, I am not able to reproduce this in Chrome, I can reproduce in Safari mobile and desktop though!

davemcorwin commented 5 years ago

ah, i see the issue. Currently, whenever the "page" changes we do a bunch of stuff including:

It looks like this is also firing when following a "hash link" (a link to a location on the current page) as well.

Correct me if I'm wrong, but my assumption is that we do NOT want to do any of the above stuff when following a link of this kind.

bpdesigns commented 5 years ago

Yes @davemcorwin for this link and for the "find treatment" link on the homepage.

Whats interesting to me is that the "find treatment" link goes to the right place on the page when clicked - sends visitor to "search" button