search

CBICA / CaPTk

Cancer Imaging Phenomics Toolkit (CaPTk) is a software platform to perform image analysis and predictive modeling tasks. Documentation: https://cbica.github.io/CaPTk
https://www.cbica.upenn.edu/captk
Other
175 stars 63 forks source link

Popup message for Perfusion Alignment #1321

Closed ashishsingh18 closed 3 years ago

ashishsingh18 commented 3 years ago

Fix #1320

sarthakpati commented 3 years ago

Closing this out. See comment from @sbakas: https://github.com/CBICA/CaPTk/issues/1320#issuecomment-698587673

ashishsingh18 commented 3 years ago

Reopening this as the changes requested by @sbakas can be done here itself.

sarthakpati commented 3 years ago

Reopening this as the changes requested by @sbakas can be done here itself.

Ashish, I have already made the changes (and substantially more stuff) in #1310.

ashishsingh18 commented 3 years ago

Reopening this as the changes requested by @sbakas can be done here itself.

Ashish, I have already made the changes (and substantially more stuff) in #1310.

@sarthakpati ..I wasn't aware that you took care of it and was working on it since it was assigned to me.

sarthakpati commented 3 years ago

Reopening this as the changes requested by @sbakas can be done here itself.

Ashish, I have already made the changes (and substantially more stuff) in #1310.

@sarthakpati ..I wasn't aware that you took care of it and was working on it since it was assigned to me.

Yeah, but after the executive decision, it made more sense to roll everything in to a single PR.

ashishsingh18 commented 3 years ago

Reopening this as the changes requested by @sbakas can be done here itself.

Ashish, I have already made the changes (and substantially more stuff) in #1310.

@sarthakpati ..I wasn't aware that you took care of it and was working on it since it was assigned to me.

Yeah, but after the executive decision, it made more sense to roll everything in to a single PR.

A message would have helped avoid duplication of work.