search

CBICA / CaPTk

Cancer Imaging Phenomics Toolkit (CaPTk) is a software platform to perform image analysis and predictive modeling tasks. Documentation: https://cbica.github.io/CaPTk
https://www.cbica.upenn.edu/captk
Other
175 stars 63 forks source link

Azure-based Docker build & push to Docker Hub repo #1354

Open AlexanderGetka-cbica opened 3 years ago

AlexanderGetka-cbica commented 3 years ago

Addresses #1344

This now causes our self-hosted Linux build on Ubuntu 16.04 to build and push to the cbica/captk repo on Docker Hub.

I know that at this time the images built on 16.04 are displaying problems in Ubuntu 20.04 -- if we need to swap around the machines / agents used to do this build, we can.

Note that this addition requires the Docker CLI, at least, to be installed on the relevant build agents. I've done this on ubuntu16.04-self-hosting in crete, and I've added the relevant information to the wiki.

This is a draft PR for now to check the builds on Azure -- I need to uncomment the conditional check before merging to master. Will ping the team when this is ready to be reviewed/merged.

sarthakpati commented 3 years ago

This seems to be uploading to docker hub, right? I saw that there were some new builds that were pushed but wasn't sure if this PR triggered it...

AlexanderGetka-cbica commented 3 years ago

Sorry @sarthakpati -- didn't see your message. This will push to Docker Hub eventually but it hasn't done so yet.

When it does, the pushes it makes will be tagged with: "latest", "azure-latest", and ${build ID}.

AlexanderGetka-cbica commented 3 years ago

OK, crete and its VMs don't have sufficient space to do a docker image build on top of all the existing build stuff. Going to move this to a Microsoft-hosted Ubuntu VM unless there are any objections to that.

sarthakpati commented 3 years ago

Hey @AlexanderGetka-cbica, seems like even the Windows agent is running out of space: https://dev.azure.com/CBICA/CaPTk/_build/results?buildId=2470&view=logs&j=e7938306-64e6-5182-a920-0c4a6e7f5962&t=d249d6a6-9285-5be7-d69d-bd87dd22518e

sarthakpati commented 3 years ago

OK, crete and its VMs don't have sufficient space to do a docker image build on top of all the existing build stuff. Going to move this to a Microsoft-hosted Ubuntu VM unless there are any objections to that.

Hey @AlexanderGetka-cbica: any update on this?

AlexanderGetka-cbica commented 3 years ago

Following some discussion with Mark, I've been intending to check if the testbed VM on crete has enough space. Need to set up a new Azure agent for this... Let me try that right now.

AlexanderGetka-cbica commented 3 years ago

Kind of forgot about this for a while... This is ready to be merged. We're now building on Ubuntu 18.04, and the pipeline will only push to Docker Hub from the current master on scheduled or manual runs.