search

CBICA / CaPTk

Cancer Imaging Phenomics Toolkit (CaPTk) is a software platform to perform image analysis and predictive modeling tasks. Documentation: https://cbica.github.io/CaPTk
https://www.cbica.upenn.edu/captk
Other
182 stars 65 forks source link

Plotting for perfusion alignment #1370

Closed ashishsingh18 closed 4 years ago

ashishsingh18 commented 4 years ago

Fix #1369

ashishsingh18 commented 4 years ago

This seems good. Re: Sarthak's comments, I think this works either way, though pass by value requires a little more memory. I think the default copy constructor on the map would be shallow, so std::map<std::string, std::vector<float>>* should negate most memory impact while still being very quickly readable.

Yeah, no change is needed. What we have is correct and avoids duplication of memory.

sarthakpati commented 4 years ago

This seems good. Re: Sarthak's comments, I think this works either way, though pass by value requires a little more memory. I think the default copy constructor on the map would be shallow, so std::map<std::string, std::vector<float>>* should negate most memory impact while still being very quickly readable.

Yeah, no change is needed. What we have is correct and avoids duplication of memory.

Alright. The changes make sense; approved.