Closed AlexanderGetka-cbica closed 3 years ago
@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe?
@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe?
Try now?
@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe?
Try now?
OK, that worked. Thanks!
Hey @AlexanderGetka-cbica @Getkablue: if you are still working on this, could convert to draft? Thanks!
This is actually done for now, I just forgot to commit my last change. This can be reviewed.
This PR contains some changes to the GUI and CLI of training module and a few changes to the back-end to just make it work while the bigger changes are pending.
This does not include the (sweeping) structural changes to the TrainingModule.cpp back-end -- this PR mostly introduces the Parameter Object pattern so as to more easily plumb data through (also, C and G optimization options are now tunable).
Those big refactors on the back-end side will come later as a PR, before the addition of the new feature selection approaches. That way, the structural changes with the existing modes will come first, then the additions as a separate PR to make it easier to review.