search

CBICA / CaPTk

Cancer Imaging Phenomics Toolkit (CaPTk) is a software platform to perform image analysis and predictive modeling tasks. Documentation: https://cbica.github.io/CaPTk
https://www.cbica.upenn.edu/captk
Other
175 stars 63 forks source link

TrainingModule parameter changes #1371

Closed AlexanderGetka-cbica closed 3 years ago

AlexanderGetka-cbica commented 3 years ago

This PR contains some changes to the GUI and CLI of training module and a few changes to the back-end to just make it work while the bigger changes are pending.

This does not include the (sweeping) structural changes to the TrainingModule.cpp back-end -- this PR mostly introduces the Parameter Object pattern so as to more easily plumb data through (also, C and G optimization options are now tunable).

Those big refactors on the back-end side will come later as a PR, before the addition of the new feature selection approaches. That way, the structural changes with the existing modes will come first, then the additions as a separate PR to make it easier to review.

AlexanderGetka-cbica commented 3 years ago

@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe?

sarthakpati commented 3 years ago

@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe?

Try now?

AlexanderGetka-cbica commented 3 years ago

@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe?

Try now?

OK, that worked. Thanks!

sarthakpati commented 3 years ago

Hey @AlexanderGetka-cbica @Getkablue: if you are still working on this, could convert to draft? Thanks!

AlexanderGetka-cbica commented 3 years ago

This is actually done for now, I just forgot to commit my last change. This can be reviewed.