CBICA / CaPTk

Cancer Imaging Phenomics Toolkit (CaPTk) is a software platform to perform image analysis and predictive modeling tasks. Documentation: https://cbica.github.io/CaPTk
https://www.cbica.upenn.edu/captk
Other
173 stars 63 forks source link

[1.8.2.Alpha] PerfusionPCA disabled from CLI, not working from GUI #1458

Closed AlexanderGetka-cbica closed 2 years ago

AlexanderGetka-cbica commented 2 years ago

Describe the bug From the CLI, attempting to use PerfusionPCA yields the following message: This functionality has been removed from this CaPTk release, and we are actively testing an optimized robust implementation that would enable generalization in multi-institutional data. We expect this to be released in our next patch release, expected in Q4 2020

From the GUI, the application will not run, or complains about missing inputs. (Waiting on clarification about this).

To Reproduce Steps to reproduce the behavior:

  1. Run PerfusionPCA from CLI, with any parameters
  2. See error OR
  3. Launch the CaPTk GUI
  4. Launch PerfusionPCA from the applications menu
  5. Application fails to run or throws an error about missing inputs.

Expected behavior The CLI error should be disabled in this alpha since as I understand it the changes to it have been made. The GUI error should not happen so long as users provide the right input.

CaPTk Version 1.8.2.Alpha

Desktop (please complete the following information):

Additional context Problem first reported by Jose Garcia.

AlexanderGetka-cbica commented 2 years ago

I cannot reproduce this on my Ubuntu installation of 1.8.2.Alpha. While the CLI is finicky (on first run, if the output dir doesn't exist, it will silently exit and not actually run until the next run, and the required input structure is very strict), it does succeed for me. Likewise, the GUI also works for me.

sarthakpati commented 2 years ago

if the output dir doesn't exist, it will silently exit

We can easily fix this, I guess?