search

CBICA / CaPTk2.0

Other
5 stars 5 forks source link

Don't pass QProgressBar to the modules #115

Open dboun opened 4 years ago

dboun commented 4 years ago

Happens in Interactive seg and maybe survival

ashishsingh18 commented 4 years ago

@dboun Could you give some more context about this?

dboun commented 4 years ago

These two modules have a SetProgressBar method.

This shouldn't be the case, they should have a progressUpdate signal that the plugin connects to the progress bar

AlexanderGetka-cbica commented 4 years ago

Survival doesn't even currently have a progress bar on the plugin (I may not have removed the associated function though). From what I remember survival doesn't give progress updates even in CaPTk 1.X. But I should be able to address this issue while adding progress updates, no problem.

dboun commented 4 years ago

PR #146 now includes fixes for this for InteractiveSegmentation.

dboun commented 4 years ago

From what I remember survival doesn't give progress updates even in CaPTk 1.X

Ok then please just remove the QProgressBar altogether from everywhere in survival. Adding progress updates is a substantial enhancement that should not be a concern for now.

AlexanderGetka-cbica commented 4 years ago

I can't find any references to QProgressBar in the current master version of survival, so it seems this is fine for now