search

CBICA / CaPTk2.0

Other
5 stars 5 forks source link

Rename plugins to upenn.cbica.captk.* and change view names #83

Closed dboun closed 4 years ago

dboun commented 4 years ago

Renaming of plugins and fix #81

dboun commented 4 years ago

-why are the resources files here?

Shouldn't they be? Can you be more specific as to which resources you are referring to?

-Didn't you want to put the plugin by organ name: upenn.cbica.captk.brain.x?

Yep, but I forgot :P I will update the PR, don't merge it yet

dboun commented 4 years ago

(last commit: Renaming upenn.cbica.captk.phiestimator to upenn.cbica.captk.brain.phiestimator)

dboun commented 4 years ago

Also changed the view names

ashishsingh18 commented 4 years ago

-why are the resources files here?

Shouldn't they be? Can you be more specific as to which resources you are referring to?

png, css, etc. Is that because the folder name got changed?

-Didn't you want to put the plugin by organ name: upenn.cbica.captk.brain.x?

Yep, but I forgot :P I will update the PR, don't merge it yet

dboun commented 4 years ago

-why are the resources files here?

Shouldn't they be? Can you be more specific as to which resources you are referring to?

png, css, etc. Is that because the folder name got changed?

Yes, I didn't change their name. Their path just changed. (Also the qrc's changed i.e. <qresource prefix="/upenn.cbica.captk.ui">

Please approve this PR if everything else is ok, because all the rest depend on this