search

CBICA / CaPTk2.0

Other
5 stars 5 forks source link

Survival plugin and module #94

Closed AlexanderGetka-cbica closed 4 years ago

AlexanderGetka-cbica commented 4 years ago

This adds the integrated CaPTk survival plugin and module in working form -- there are probably (definitely) some changes to be made in terms of naming conventions / relative paths / includes / defines as well as better integrating the module's ability to report back to the plugin with relevant data.

But it does run and function, so it's a start.

Please submit edits/changes as a PR to my survival-dev branch.

AlexanderGetka-cbica commented 4 years ago

@ashishsingh18 regarding the commented-out code, I initially left it in on the basis that it was present in CaPTk's survival code -- I have pruned it and will update this momentarily.

ashishsingh18 commented 4 years ago

@ashishsingh18 regarding the commented-out code, I initially left it in on the basis that it was present in CaPTk's survival code -- I have pruned it and will update this momentarily.

If you want to leave it there, while work is still in progress, that's fine. But please open an issue to clean it up and also leave ample comments.

AlexanderGetka-cbica commented 4 years ago

I actually meant that the code was commented out even when I first copied it, so I did not feel bad at all completely removing it from this version. I believe I got everything, so please check/approve if all is good