Enable packaging with briefcase

CBICA / niCHART

The neuro-imaging brain aging chart [niCHART] is a comprehensive solution to analyze standard structural and functional brain MRI data across studies. [niCHART] and the associated pre-processing tools implement computational morphometry, functional signal analysis, quality control, statistical harmonization, data standardization, interactive visual

https://cbica.github.io/niCHART/

Other

13 stars 8 forks source link

Enable packaging with briefcase #166

Closed AbdulkadirA closed 2 years ago

AbdulkadirA commented 2 years ago

This PR enables packaging installers for Linux, Windows, and macOS.

[x] Windows 10/11
[x] macOS
[ ] Linux | will be addressed in the future

AbdulkadirA commented 2 years ago

The installation package can be built as follows (tested on Windows 11)

git clone https://github.com/CBICA/NiBAx.git
cd NiBAx
git fetch origin refs/pull/166/head
git checkout -b briefcase FETCH_HEAD
python -m venv .env
source .env/bin/activate
python -m pip install -U pip briefcase
python -m pip install -U MarkupSafe==2.0.1
briefcase create
briefcase build
briefcase run # will open the application, close to continue
briefcase package

The installer will appear in the windows subfolder. For macOS and Linux, the installers will appear in the linux and macOS subfolders, respectively.

melhemr commented 2 years ago

Hi @AbdulkadirA

Everything here has worked well for me, but I did get this one pop up message:

Is this expected?

AbdulkadirA commented 2 years ago

@melhemr Thanks. At what step did this happen? This indicates that you are lacking certain developer tools necessary to build the package. It is not unexpected. Note, the last command should read briefcase package --no-sign for macOS.

melhemr commented 2 years ago

@AbdulkadirA this happened at briefcase package, and it happened again after briefcase package --no-sign. Should I just install the package?

AbdulkadirA commented 2 years ago

@AbdulkadirA this happened at briefcase package, and it happened again after briefcase package --no-sign. Should I just install the package?

Yes. As far as I know this should be safe. To be extra safe, you could install the XCode command line tools separately.

melhemr commented 2 years ago

@AbdulkadirA I have installed the command line tools, and proceeded with briefcase package --no-sign

Right now, this has come up:

And the icon for the NiBAx app is a bumblebee. Is this correct?

AbdulkadirA commented 2 years ago

And the icon for the NiBAx app is a bumblebee. Is this correct?

@melhemr Yes, this is expected. Can you install (move to Applications folder) and run NiBAx by double-clicking it?

melhemr commented 2 years ago

@AbdulkadirA Yes, that works, and I'm also able to use mac search to find it and open it as well. Should I merge?

AbdulkadirA commented 2 years ago

@melhemr I updated the description and marked the PR as ready for review. Thanks.