search

CBIIT / R-cometsAnalytics

R package development for COMETS Analytics
12 stars 10 forks source link

COMETS 1.3. Add "model" table to zip file #29

Closed steven-moore closed 6 years ago

steven-moore commented 6 years ago

My IMS collaborators have requested that we add the model tab to our zip file so that they can double-check that the correct models were run and have it documented. I think this is a great idea. We may want to add the varmap as well.

steven-moore commented 6 years ago

Also "Metabolites" tab too.

wobenshain commented 6 years ago

Are we just supposed to be copying the two of the tabs from the input to new files in the archive? Should we just include the input file in the output archive?

steven-moore commented 6 years ago

Copy the two tabs over but not anything else.

From: Wesley Obenshain [mailto:notifications@github.com] Sent: Thursday, February 8, 2018 4:19 PM To: CBIIT/R-cometsAnalytics R-cometsAnalytics@noreply.github.com Cc: Moore, Steve (NIH/NCI) [E] steve.moore@nih.gov; Author author@noreply.github.com Subject: Re: [CBIIT/R-cometsAnalytics] COMETS 1.3. Add "model" table to zip file (#29)

Are we just supposed to be copying the two of the tabs from the input to new files in the archive? Should we just include the input file in the output archive?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CBIIT/R-cometsAnalytics/issues/29#issuecomment-364251602, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhG9Tc7DIgHkj1lazus55OW-VY9-T3Tdks5tS2TKgaJpZM4RrwqY.

steven-moore commented 6 years ago

To further clarify, copying over any of the actual original participant data will get us in a world of trouble.

S

From: Moore, Steve (NIH/NCI) [E] Sent: Thursday, February 8, 2018 4:26 PM To: 'CBIIT/R-cometsAnalytics' reply@reply.github.com; CBIIT/R-cometsAnalytics R-cometsAnalytics@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [CBIIT/R-cometsAnalytics] COMETS 1.3. Add "model" table to zip file (#29)

Copy the two tabs over but not anything else.

From: Wesley Obenshain [mailto:notifications@github.com] Sent: Thursday, February 8, 2018 4:19 PM To: CBIIT/R-cometsAnalytics R-cometsAnalytics@noreply.github.com<mailto:R-cometsAnalytics@noreply.github.com> Cc: Moore, Steve (NIH/NCI) [E] steve.moore@nih.gov<mailto:steve.moore@nih.gov>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [CBIIT/R-cometsAnalytics] COMETS 1.3. Add "model" table to zip file (#29)

Are we just supposed to be copying the two of the tabs from the input to new files in the archive? Should we just include the input file in the output archive?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CBIIT/R-cometsAnalytics/issues/29#issuecomment-364251602, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhG9Tc7DIgHkj1lazus55OW-VY9-T3Tdks5tS2TKgaJpZM4RrwqY.

steven-moore commented 6 years ago

I have tested, and the whole input file is currently being passed through. This is the wrong functionality. The "SubjectMetabolites" and "SubjectData" tabs should first be extracted, then the remaining tabs should be passed onward. This is a critical priority.

wobenshain commented 6 years ago

Looks like I accidentally removed the code that was saving the modified input at some point. I've added it back in and reworked the code so that it should no longer be possible to package up the original input file.

wobenshain commented 6 years ago

(This is on dev, since I've been informed that test may be in use at the moment.)

steven-moore commented 6 years ago

Thanks Wesley.

I will be done my testing at 3, and I will tell my contractor to stop testing at 3:30. So, any time after 3:30 is fine for making this change.

S

From: Wesley Obenshain [mailto:notifications@github.com] Sent: Tuesday, February 20, 2018 2:08 PM To: CBIIT/R-cometsAnalytics R-cometsAnalytics@noreply.github.com Cc: Moore, Steve (NIH/NCI) [E] steve.moore@nih.gov; Author author@noreply.github.com Subject: Re: [CBIIT/R-cometsAnalytics] COMETS 1.3. Add "model" table to zip file (#29)

(This is on dev, since I've been informed that test may be in use at the moment.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CBIIT/R-cometsAnalytics/issues/29#issuecomment-367084419, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhG9TSmBemD4SummKBqhH_MaSAtdaXXIks5tWxgBgaJpZM4RrwqY.

wobenshain commented 6 years ago

Upon test now.

steven-moore commented 6 years ago

Resolved! Thanks--this is perfect. Issue is closed.