search

CBIIT / R-cometsAnalytics

R package development for COMETS Analytics
12 stars 10 forks source link

COMETS 1.3. Minor warning issue #36

Closed steven-moore closed 6 years ago

steven-moore commented 6 years ago

I like the addition of the warnings--it will make testing easier.

Now that they are visible, there may be some tweaks needed. One such tweak is that, when running an analysis stratified by BMI, I received the following warning: "Warning: one of your models specifies bmi_grp as a stratification but that variable only has one possible value. Model will run without bmi_grp stratified"

There is a strata of BMI that had very few observations, but bmi_grp itself definitely has more than one possible value, as evidenced in the screenshot below. Any suggestions for how to modify wording ?

image

ewymathe commented 6 years ago

How about: Warning: one of your models specifies bmi_grp as a stratification but when bmi_group is X, then there is only one individual. Model will run without bmi_group=X stratification where X is the actual group.

steven-moore commented 6 years ago

I like this--that's perfect

steven-moore commented 6 years ago

This issue is redundant with issue #38 and so I am closing it.