CBIIT / R-cometsAnalytics

R package development for COMETS Analytics
12 stars 10 forks source link

Comets 1.3. Display in interactive mode needs modification #37

Closed steven-moore closed 6 years ago

steven-moore commented 6 years ago

In the latest update, the display of results onscreen is using the wrong column of metabolite names in interactive mode. The display is correct, however, in batch mode. Screenshots of each are below.

Interactive mode:

image

Batch mode (model age.1):

image

steven-moore commented 6 years ago

In addition, the correlation estimates and p-values are sometimes not rounded appropriately. I believe this happens primarily when there is a problem estimating the correlations for at least one metabolite, per the example below.

image

wobenshain commented 6 years ago

The names issue is in the package. We treat the output the same way regardless of whether it's interactive or model and for some reason the interactive mode outputs the 'outcome' variable to match the 'outcomespec' variable.

steven-moore commented 6 years ago

Thanks for clarifying--it's switched to Ewy

wobenshain commented 6 years ago

Number format issues has been patched. It looks like the backend had been switched to returning strings (instead of numerics), at least for some results. I added code for the correlation value as well as patching the pvalue to account for strings.

steven-moore commented 6 years ago

OK, looks good. The correlations, however, should show three digits, per prior code.

steven-moore commented 6 years ago

To clarify, the correlations should NOT be in scientific notation, but should be listed to three digits after the decimal.

ellatemprosa commented 6 years ago

fixed this issue with commit https://github.com/CBIIT/R-cometsAnalytics/commit/cc16fd209dba6d3518913d2aadbb1a0b43ab6f0b