CBIIT / R-cometsAnalytics

R package development for COMETS Analytics
12 stars 10 forks source link

COMETS 1.3. Minor tweaks to warning messages #38

Closed steven-moore closed 6 years ago

steven-moore commented 6 years ago

For batch mode, model age.1, lets replace existing warning message with "We removed one or more dummy variables that were redundant (i.e. perfectly correlated with another variable)."

Also is it possible to specify the variable?

steven-moore commented 6 years ago

For age 2.2., the current message is " Warning: Model Age.2.2 BMI stratified has strata (bmi_grp=4) with less than 15 observations. Model will not be run"

The second sentence here should read instead "Model will not be run for this stratum."

steven-moore commented 6 years ago

Updated to include milestone label

steven-moore commented 6 years ago

The model below: Exposure: Age Outcome: All metabolites Adjustment: multivitamin bmi_grp smk_grp

returns an error message that is likely to be uninformative to user: " argument 'pattern' has length > 1 and only the first element will be used"

ellatemprosa commented 6 years ago

this is actually a bug steve, good catch! i will fix this

ellatemprosa commented 6 years ago

for multiple adjustment vars, it was only taking the first one, i updated the code so that all vars are matched correctly and included adjspec to output to show what adjustments were added to model

ellatemprosa commented 6 years ago

@kailingchen please redeploy

ellatemprosa commented 6 years ago

addressed with this commit https://github.com/CBIIT/R-cometsAnalytics/commit/c35674a744ef6025c5f6d6f9c01a749bbc367b37

steven-moore commented 6 years ago

There are some wordsmithing issues we could fix, but in general I am satisfied with COMETS 1.3 as it stands and think we should move to production.

steven-moore commented 6 years ago

I would like to propose that we change this to a 1.4 milestone.

ewymathe commented 6 years ago

Warning fixed.