search

CBIIT / R-cometsAnalytics

R package development for COMETS Analytics
12 stars 10 forks source link

COMETS 1.3: "Run model" is sensitive to caps in ".XLSX" but, like "check integrity", it should not be #44

Closed steven-moore closed 6 years ago

steven-moore commented 6 years ago

If the extension in the data input file is capitalized (".XLSX"), the file will be able to complete the "Integrity check" but will return a warning message at the "Run model" stage, per the below:

screesnhot

screen2

ellatemprosa commented 6 years ago

so strange... i will see what i find

ewymathe commented 6 years ago

I am finding this error very confusing. Are you referring to the fact that the file is called ".XLSX" and not ".xlsx"? This should have no bearing at all on the analyses. The only time this filename is used is when the data is read in. Once it's read in, the other functions do not call that file. This may have something to do with the GUI (one should check whether the file is read in again once the 'Run Model' button is pressed).

steven-moore commented 6 years ago

Yes. And I think it probably is related to the GUI.

S

From: Ewy Mathe [mailto:notifications@github.com] Sent: Wednesday, May 9, 2018 2:50 PM To: CBIIT/R-cometsAnalytics R-cometsAnalytics@noreply.github.com Cc: Moore, Steve (NIH/NCI) [E] steve.moore@nih.gov; Author author@noreply.github.com Subject: Re: [CBIIT/R-cometsAnalytics] COMETS 1.3: "Run model" is sensitive to caps in ".XLSX" but, like "check integrity", it should not be (#44)

I am finding this error very confusing. Are you referring to the fact that the file is called ".XLSX" and not ".xlsx"? This should have no bearing at all on the analyses. The only time this filename is used is when the data is read in. Once it's read in, the other functions do not call that file. This may have something to do with the GUI (one should check whether the file is read in again once the 'Run Model' button is pressed).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CBIIT/R-cometsAnalytics/issues/44#issuecomment-387838789, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhG9TbZvYqGfYxca6lBRtyOQM3bTtWOTks5twzpAgaJpZM4Tqyy5.

steven-moore commented 6 years ago

The "Run model" was checking the file again on the website end. Will need to be fixed on 1.4. The data is saved in the created list--everything is there.

In the meantime, the specific ".XLSX" issue has been fixed.